Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: expose view analyzed crates command #6266

Merged

Conversation

piotmag769
Copy link
Collaborator

@piotmag769 piotmag769 commented Aug 23, 2024

Closes #6089

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @mkaput)

Copy link
Contributor

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, and @piotmag769)


-- commits line 2 at r1:

Suggestion:

- 2f137f7: LS: expose view analyzed crates command
  
  fix #6089

vscode-cairo/package.json line 79 at r1 (raw file):

      {
        "command": "cairo.viewAnalyzedCrates",
        "title": "View crates currently analyzed by LS",

Suggestion:

View currently analyzed crates

vscode-cairo/package.json line 138 at r1 (raw file):

    ],
    "configurationDefaults": {
      "explorer.fileNesting.enabled": true,

change out of scope of this PR

Copy link
Collaborator Author

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, and @mkaput)


-- commits line 2 at r1:
? i don't get it xD


vscode-cairo/package.json line 79 at r1 (raw file):

      {
        "command": "cairo.viewAnalyzedCrates",
        "title": "View crates currently analyzed by LS",

Done.


vscode-cairo/package.json line 138 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

change out of scope of this PR

Done.

@piotmag769 piotmag769 requested a review from mkaput August 26, 2024 12:57
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, and @mkaput)

Copy link
Contributor

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)


-- commits line 2 at r1:

Previously, piotmag769 (Piotr Magiera) wrote…

? i don't get it xD

link PR in commit/PR description

Copy link
Collaborator Author

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)

Copy link
Contributor

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)

@piotmag769 piotmag769 added this pull request to the merge queue Aug 26, 2024
@piotmag769 piotmag769 removed this pull request from the merge queue due to a manual request Aug 26, 2024
Copy link
Contributor

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)

@piotmag769 piotmag769 added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 26, 2024
@piotmag769 piotmag769 added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2024
@piotmag769 piotmag769 added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit e28e48a Aug 26, 2024
45 checks passed
@piotmag769 piotmag769 deleted the 6089-provide-cairoviewanalyzedcrates-as-a-command-in-vscode branch August 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide cairo/viewAnalyzedCrates as a command in VSCode
3 participants