fixed a bug where strings with will get the wrong sha256 value

[TomerStarkware]

This change is 

[orizi]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

corelib/src/test/sha256_test.cairo line 15 at r1 (raw file):

    assert_eq!(a, 0x9834876d);
    let [a, _, _, _, _, _, _, _,] = compute_sha256_byte_array(@"aaaa");
    assert_eq!(a, 0x61be55a8);

extend these tests as well.

Code quote:

    let [a, _, _, _, _, _, _, _,] = compute_sha256_byte_array(@"a");
    assert_eq!(a, 0xca978112);
    let [a, _, _, _, _, _, _, _,] = compute_sha256_byte_array(@"aa");
    assert_eq!(a, 0x961b6dd3);
    let [a, _, _, _, _, _, _, _,] = compute_sha256_byte_array(@"aaa");
    assert_eq!(a, 0x9834876d);
    let [a, _, _, _, _, _, _, _,] = compute_sha256_byte_array(@"aaaa");
    assert_eq!(a, 0x61be55a8);

---

corelib/src/test/sha256_test.cairo line 408 at r1 (raw file):

            3889463563,
            3109547134,
            3732685805

make all tests with hex numeric values.

Code quote:

            3545823548,
            3587795446,
            676063049,
            3347034665,
            1546494401,
            3889463563,
            3109547134,
            3732685805

[orizi]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @TomerStarkware)

---

corelib/src/test/sha256_test.cairo line 410 at r1 (raw file):

            3732685805
        ]
    );

also - consider adding a test helper function converting a u32 array to u256 to vastly shorten the tests.

fn to_u256(arr: [u32; 8]) -> u256 {
     let mut value: u256 = 0;
     for word in arr.span() {
          value *= 0x100000000;
          value += word.into();
     }
     value
}

[TomerStarkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/test/sha256_test.cairo line 15 at r1 (raw file):

Previously, orizi wrote…

extend these tests as well.

Done.

---

corelib/src/test/sha256_test.cairo line 408 at r1 (raw file):

Previously, orizi wrote…

make all tests with hex numeric values.

Done.

---

corelib/src/test/sha256_test.cairo line 410 at r1 (raw file):

Previously, orizi wrote…

also - consider adding a test helper function converting a u32 array to u256 to vastly shorten the tests.

fn to_u256(arr: [u32; 8]) -> u256 {
     let mut value: u256 = 0;
     for word in arr.span() {
          value *= 0x100000000;
          value += word.into();
     }
     value
}

Done.

[orizi]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

corelib/src/test/sha256_test.cairo line 12 at r3 (raw file):

    value
}
#[test]

put after the test, have emptyline between the functions and doc.

also - consider just making it also call the sha itself:

Suggestion:

use core::starknet::SyscallResultTrait;
use core::sha256::compute_sha256_byte_array;

fn sha256_as_u256(input: ByteArray) -> u256 {
    let hash_result = compute_sha256_byte_array(@input);
    let mut value: u256 = 0;
    for word in hash_result.span() {
        value *= 0x100000000;
        value = value + (*word).into();
    };
    value
}

#[test]

[TomerStarkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/test/sha256_test.cairo line 12 at r3 (raw file):

Previously, orizi wrote…

put after the test, have emptyline between the functions and doc.

also - consider just making it also call the sha itself:

Done.

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)