-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mutable_* to *_mut. #6028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 17 files at r1, all commit messages.
Reviewable status: 6 of 17 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-starknet/src/plugin/storage_node.rs
line 141 at r1 (raw file):
fn mutable_suffix(&self) -> String { if self.is_mutable { "_mut".to_string() } else { "".to_string() } }
Suggestion:
/// Returns the mutable prefix of camelcase names.
fn mutable_camelcase(&self) -> &'static str {
if self.is_mutable { "Mutable" } else { "" }
}
/// Returns the mutable suffix for functions.
fn mutable_suffix(&self) -> &'static str {
if self.is_mutable { "_mut" } else { "" }
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 17 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
b80cd94
to
43d073b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 17 of 21 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/src/plugin/storage_node.rs
line 141 at r1 (raw file):
fn mutable_suffix(&self) -> String { if self.is_mutable { "_mut".to_string() } else { "".to_string() } }
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
43d073b
to
f047a70
Compare
commit-id:e6beec18
f047a70
to
f481409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
This change is