Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mutable_* to *_mut. #6028

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Change mutable_* to *_mut. #6028

merged 1 commit into from
Jul 16, 2024

Conversation

gilbens-starkware
Copy link
Contributor

@gilbens-starkware gilbens-starkware commented Jul 16, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 17 files at r1, all commit messages.
Reviewable status: 6 of 17 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-starknet/src/plugin/storage_node.rs line 141 at r1 (raw file):

    fn mutable_suffix(&self) -> String {
        if self.is_mutable { "_mut".to_string() } else { "".to_string() }
    }

Suggestion:

    /// Returns the mutable prefix of camelcase names.
    fn mutable_camelcase(&self) -> &'static str {
        if self.is_mutable { "Mutable" } else { "" }
    }
    /// Returns the mutable suffix for functions.
    fn mutable_suffix(&self) -> &'static str {
        if self.is_mutable { "_mut" } else { "" }
    }

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 17 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

@gilbens-starkware gilbens-starkware force-pushed the spr/dev-v2.7.0/e6beec18 branch 2 times, most recently from b80cd94 to 43d073b Compare July 16, 2024 12:04
Copy link
Contributor Author

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 17 of 21 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-starknet/src/plugin/storage_node.rs line 141 at r1 (raw file):

    fn mutable_suffix(&self) -> String {
        if self.is_mutable { "_mut".to_string() } else { "".to_string() }
    }

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

commit-id:e6beec18
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Jul 16, 2024
Merged via the queue into dev-v2.7.0 with commit bd44f91 Jul 16, 2024
87 checks passed
@orizi orizi deleted the spr/dev-v2.7.0/e6beec18 branch July 31, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants