Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic test for closure. #6027

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

ilyalesokhin-starkware
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware commented Jul 16, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @Tomer-StarkWare)


crates/cairo-lang-semantic/src/expr/test_data/closure line 1 at r1 (raw file):

//! > Const

Fix name

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-semantic/src/expr/test_data/closure line 1 at r1 (raw file):

Previously, orizi wrote…

Fix name

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Tomer-StarkWare)

@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit fdd8955 Jul 16, 2024
44 checks passed
@ilyalesokhin-starkware ilyalesokhin-starkware deleted the ilya/closure_test branch July 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants