This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(factories): CreateShorthandOptions should be typed #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
September 3, 2019 16:58
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
- Coverage 69.89% 69.88% -0.01%
==========================================
Files 890 890
Lines 7785 7784 -1
Branches 2275 2250 -25
==========================================
- Hits 5441 5440 -1
Misses 2334 2334
Partials 10 10
Continue to review full report at Codecov.
|
@layershifter please let me know what you think |
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
added
needs author changes
Author needs to implement changes before merge
🗑️ chore
and removed
🚀 ready for review
labels
Sep 9, 2019
…ust-ui/react into fix/create-shorthand-options-types
layershifter
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: ugly code ahead