Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(factories): CreateShorthandOptions should be typed #1886

Merged
merged 13 commits into from
Sep 10, 2019
Merged

fix(factories): CreateShorthandOptions should be typed #1886

merged 13 commits into from
Sep 10, 2019

Conversation

lucivpav
Copy link
Contributor

@lucivpav lucivpav commented Sep 3, 2019

Warning: ugly code ahead

@vercel vercel bot temporarily deployed to staging September 5, 2019 12:30 Inactive
@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #1886 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
- Coverage   69.89%   69.88%   -0.01%     
==========================================
  Files         890      890              
  Lines        7785     7784       -1     
  Branches     2275     2250      -25     
==========================================
- Hits         5441     5440       -1     
  Misses       2334     2334              
  Partials       10       10
Impacted Files Coverage Δ
...kages/react/src/components/Accordion/Accordion.tsx 95.89% <ø> (ø) ⬆️
packages/react/src/components/Tree/Tree.tsx 74.25% <ø> (ø) ⬆️
...ackages/react/src/components/Dropdown/Dropdown.tsx 88.04% <ø> (ø) ⬆️
packages/react/src/components/Tree/TreeItem.tsx 71.42% <ø> (ø) ⬆️
packages/react/src/types.ts 50% <ø> (ø) ⬆️
...mponents/HierarchicalTree/HierarchicalTreeItem.tsx 75% <ø> (ø) ⬆️
...c/components/HierarchicalTree/HierarchicalTree.tsx 93.75% <ø> (ø) ⬆️
...ges/react/src/components/MenuButton/MenuButton.tsx 52.94% <100%> (ø) ⬆️
packages/react/src/lib/factories.ts 94.36% <100%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f35b0...2ad7abf. Read the comment docs.

@lucivpav
Copy link
Contributor Author

lucivpav commented Sep 5, 2019

@layershifter please let me know what you think

@layershifter layershifter added needs author changes Author needs to implement changes before merge 🗑️ chore and removed 🚀 ready for review labels Sep 9, 2019
@vercel vercel bot temporarily deployed to staging September 10, 2019 10:03 Inactive
layershifter
layershifter approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lucivpav lucivpav merged commit f838312 into master Sep 10, 2019
@lucivpav lucivpav deleted the fix/create-shorthand-options-types branch September 10, 2019 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
🗑️ chore needs author changes Author needs to implement changes before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucivpav @layershifter