Update StFstFastSimMaker to write hits into the StFstHitCollection #700
Conversation
…ction (mimicing the real data reco chain) Add a function to StFstHit to allow setting the disk, wedge, and sensor for sim hits.
jdbrice
requested review from
sunxuhit,
yezhenyu2003,
techuan-huang and
klendathu2k
as code owners
|
The test error does not seem to be related to the code changes: Looks like a network glitch. I just restarted the failed job to see if it passes this time |
| @@ -221,10 +237,13 @@ void StFstFastSimMaker::FillSilicon(StEvent *event) { | |||
| double xc = X0[disk_index]; | |||
| double yc = Y0[disk_index]; | |||
|
|
|||
| // This z-offset is used to shift the hits | |||
| // to the center of the FST where the tracking planes are defined | |||
| const double z_delta = 1.755; | |||
There was a problem hiding this comment.
Any chance this value can be extracted from the geometry?
|
|
||
| if ( mGEANTPassthrough ){ | ||
| LOG_INFO << "FST Hits using GEANT xyz directly (no raster etc.)" << endm; | ||
| } | ||
|
|
||
| if (mRaster > 0) |
There was a problem hiding this comment.
Is there still a need to randomize the X,Y center of each plane?
There was a problem hiding this comment.
I am not sure what you mean? Maybe you mean blur the position of the hits according to a resolution - thats not a bad idea. I can add that, but please let me know if you meant something different
There was a problem hiding this comment.
It looks like I commented on the wrong line of code. Just so that we're on the same page, I'm referring to lines 157 and 158, and the if ( mRaster>0 ) block on line 164.
This code appears suspect to me. It doesn't smear the hit positions. It systematically shifts the (x,y) center of each disk to the vertices of a hexagon of 'radius' mRaster. As I recall, the idea was to provide a simple way to introduce a small stereo angle between the different planes, to improve tracking resolution during design studies. The class defaults to mRaster=0, so... it probably hasn't caused a problem. But it looks to me to be dead code that no longer serves a purpose, and thus should be cleaned up. Time being at a premium... at a minimum I would eliminate any setter methods.
There was a problem hiding this comment.
Thanks - this is taken care of in d8801c1. I removed the options to set Raster and removed the additional logic in the main code.
There was a problem hiding this comment.
@klendathu2k if you are good with this can you approve?
|
@klendathu2k - does this look good to you now? |
as is done for the real data reco chain. I continue to write hits into the StRnDCollection, but this is no longer used by downstream code.
Also add a function to StFstHit to allow setting the disk, wedge, and sensor for sim hits. Does not change the StFstHit data structure.