Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Allow other field passing in generate besides input_ids #125

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

frankaging
Copy link
Collaborator

Description

In generate() call, we only pass in the input_ids field and rely on huggingface module to populate the attention mask fields. We now pass in the whole user input dict instead.

Testing Done

Tutorial test run passed.

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • I have attached the testing log above
  • I provide enough comments to my code
  • I have changed documentations
  • I have added tests for my changes

@frankaging frankaging merged commit 83fe20f into main Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants