Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to signature.py #964

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rpgoldman
Copy link
Contributor

@rpgoldman rpgoldman commented May 3, 2024

Address #962

This is substantially complicated by the use of Pydantic.

/cc @thomasahle

@rpgoldman
Copy link
Contributor Author

I could definitely use help here. I got started just fixing issue #962 , but tried to add more type hints, and have been having issues because mypy does not seem to understand that Signature() is a class-constructor, not an instance-constructor, and also because it is confused by its signature (inherited from BasicModel, I believe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant