Add Tests for extend generation logic #1184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mikeedjones , thanks for the PR. can you rebase to main and push to retrieve the latest tests? |
|
Hi @arnavsinghvi11 - updated - thanks! |
|
Hi @arnavsinghvi11 Is there anything else which needs to be added to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for extend generation logic to avoid any further breaking changes (#920) which must then be reverted (#1169)
I'm not sure the behaviour currently exhbitied is intended? I have included the generation logs as a comment in each test to illustrate how the lm is being prompted to show the DummyLM responses in context.
Adds tests to illustrate issue #1232 and to test against any solution for that issue.
Cheers