Adding in a rockset retriever class #1146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._rockset_collection_source_key]].values | ||
| passages.extend(data) | ||
|
|
||
| # Return type not changed, needs to be a Prediction object. But other code will break if we change it. |
There was a problem hiding this comment.
comment to be addressed? This can be a dspy.Prediction(passages=...).
|
Thanks @danpechi for the PR! Couple of changes needed to merge:
It would also be great if you could add documentation for the Rockset RM to provide context as done for the RMs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the input can be finicky; it works with something like:
str(openai_client.embeddings.create(model="text-embedding-ada-002", input=[question]).data[0].embedding)this has some inflexibility wrt underlying schema, ie all results are coming from a singular vector db collection
note: rockset doesn't have a 'retrieve' function, it just leverages cosine_sim
this is mostly meant for singular questions, and not batch inference