Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System prompt support for databricks module #1130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blakekleinhans
Copy link

@blakekleinhans blakekleinhans commented Jun 11, 2024

Found this necessary for guiding output length when Signature descriptions weren't impactful. Would be interesting to see system prompt integration in optimizers.

Copy link
Collaborator

@Shangyint Shangyint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would it be possible to also add a fallback so that when no system_prompt is provided we can just use "You are a helpful assistant."?

@blakekleinhans
Copy link
Author

blakekleinhans commented Jun 13, 2024

I wrote it to match what was in the GPT3 module and thought it would be nice to allow for the None case which uses the endpoint's own default system prompt (Databricks - Docs)? If you want to retain consistency with existing DSPy programs we could make that one the default value for the system_prompt argument?

@arnavsinghvi11
Copy link
Collaborator

I think it would actually be fine to leave the default system prompt as None (since changing it for GPT3 will break existing caches). but it would be great to support Databricks' default system prompts for dspy.Databricks with this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants