Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dspy): fix save/load for predict method #1046

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(dspy): fix save/load for predict method #1046

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4efb13f
fix(dspy): fix save/load for predict method
GFarnon May 20, 2024
178c1e8
fix(dspy): add fallback to previous load method
GFarnon May 20, 2024
a7c5308
style(dspy): run ruff fix
GFarnon May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 22 additions & 6 deletions dspy/predict/predict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,13 @@ def dump_state(self):
# Cache the signature instructions and the last field's name.
state["signature_instructions"] = self.signature.instructions

*_, last_key = self.signature.fields.keys()
state["signature_prefix"] = self.signature.fields[last_key].json_schema_extra["prefix"]
field_details = {}
for key, field in self.signature.fields.items():
field_details[key] = {
"prefix": field.json_schema_extra.get("prefix", ""),
"desc": field.json_schema_extra.get("desc", ""),
}
state["signature_field_details"] = field_details

return state

Expand All @@ -52,10 +57,21 @@ def load_state(self, state):
instructions = state["signature_instructions"]
self.signature = self.signature.with_instructions(instructions)

if "signature_prefix" in state:
prefix = state["signature_prefix"]
*_, last_key = self.signature.fields.keys()
self.signature = self.signature.with_updated_fields(last_key, prefix=prefix)
if "signature_field_details" in state:
field_details = state["signature_field_details"]
for key, details in field_details.items():
prefix = details.get("prefix", "")
desc = details.get("desc", "")
self.signature = self.signature.with_updated_fields(
key, prefix=prefix, desc=desc,
)
else:
# Fallback to the previous method
if "signature_prefix" in state:
prefix = state["signature_prefix"]
*_, last_key = self.signature.fields.keys()
self.signature = self.signature.with_updated_fields(last_key, prefix=prefix)


def __call__(self, **kwargs):
return self.forward(**kwargs)
Expand Down