Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing fails on AssertionError when using OpenIE (v3.9.2) #1082

Closed
manzurola opened this issue Sep 1, 2020 · 29 comments
Closed

Parsing fails on AssertionError when using OpenIE (v3.9.2) #1082

manzurola opened this issue Sep 1, 2020 · 29 comments

Comments

@manzurola
Copy link

manzurola commented Sep 1, 2020 •
edited
Loading

Happens with the following sentence, under version 3.9.2, only when adding openIE annotator:

It was a long and stern face, but with eyes that twinkled in a kindly way.

stack trace:

java.lang.AssertionError at edu.stanford.nlp.naturalli.Util.cleanTree(Util.java:324) at edu.stanford.nlp.naturalli.OpenIE.annotateSentence(OpenIE.java:463) at edu.stanford.nlp.naturalli.OpenIE.lambda$annotate$2(OpenIE.java:547) at java.base/java.util.ArrayList.forEach(ArrayList.java:1540) at edu.stanford.nlp.naturalli.OpenIE.annotate(OpenIE.java:547) at edu.stanford.nlp.pipeline.AnnotationPipeline.annotate(AnnotationPipeline.java:76) at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:637) at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:629)

to replicate:

        Properties props = new Properties();
        props.setProperty("annotators", "tokenize,ssplit,pos,lemma,ner,depparse,natlog,openie");
        StanfordCoreNLP pipeline = new StanfordCoreNLP(props);

        String text = "It was a long and stern face, but with eyes that twinkled in a kindly way.";

        CoreDocument document = new CoreDocument(text);
        pipeline.annotate(document);

works fine if openie is disabled, with other sentences, or when using https://corenlp.run/ so looks like it's fixed in later versions but I did not verify it locally as I can't upgrade at the moment anyway.

advice much appreciated
@manzurola manzurola changed the title AssertionError at edu.stanford.nlp.naturalli.Util.cleanTree(Util.java:324) with OpenIE (v3.9.2) Parsing fails on AssertionError when using OpenIE (v3.9.2) Sep 1, 2020
@manzurola
Copy link
Author

manzurola commented Sep 1, 2020 •
edited
Loading

could be related to https://github.com/stanfordnlp/CoreNLP/issues/804

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Sep 1, 2020 via email

@AngledLuffa
Copy link
Contributor

Is there some reason you can't update?

@manzurola
Copy link
Author

Thanks John. Updating to v4 was a low priority task for now but we bumped it up, did a quick demo and indeed the error has been resolved in v4. No other errors present for now and I will happily update if otherwise.
Your hard work is much appreciated, thanks again 🤘

@amracel
Copy link

amracel commented Dec 1, 2021 •
edited
Loading

I'm hoping this comment goes in, even though the issue is closed. I'm using version 4.3.2 and still having the problem listed. My code is similar to what is shown in the example. Here's the stack trace:

java.lang.AssertionError
	at edu.stanford.nlp.naturalli.Util.cleanTree(Util.java:324)
	at edu.stanford.nlp.naturalli.OpenIE.annotateSentence(OpenIE.java:474)
	at edu.stanford.nlp.naturalli.OpenIE.lambda$annotate$2(OpenIE.java:558)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at edu.stanford.nlp.naturalli.OpenIE.annotate(OpenIE.java:558)
	at edu.stanford.nlp.pipeline.AnnotationPipeline.annotate(AnnotationPipeline.java:76)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:655)
	at mil.threesixtythirdisrw.nlp.openie.classfinder.util.OpenIESeparator.annotateDoc(OpenIESeparator.java:45)
	at mil.threesixtythirdisrw.nlp.openie.classfinder.util.OpenIESeparatorTest.testSubstitutions(OpenIESeparatorTest.java:83)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:95)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:91)
	at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:60)
	at org.eclipse.jdt.internal.junit5.runner.JUnit5TestReference.run(JUnit5TestReference.java:98)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:529)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:756)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:452)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)

The paragraph I sent it was:
Unmanned systems are machines that operate under a “sense,” “think,” “act” paradigm. That is, they are distinguished from regular machines not just by the fact that there is no human inside, but also by the fact that they carry sensors that gather information about the world around them, processors that use that information to make appropriate decisions, and effectors that act to create change in the world around the machine, such as by movement or firing a weapon. They do not merely remove the human from risk, changing our very concept of the role of a warrior, but in so doing reshape many of the foundational concepts of what war itself entails.

@AngledLuffa
Copy link
Contributor

I'm afraid "similar" doesn't narrow it down enough. I did this and it didn't crash. If you can be more specific about how to cause the crash, I'll try to fix it.

import java.util.*;
import edu.stanford.nlp.pipeline.*;

class foo {
  public static void main(String[] args) {
    Properties props = new Properties();
    props.setProperty("annotators", "tokenize,ssplit,pos,lemma,ner,depparse,natlog,openie");
    StanfordCoreNLP pipeline = new StanfordCoreNLP(props);

    String text = "Unmanned systems are machines that operate under a “sense,” “think,” “act” paradigm. That is, they are distinguished from regular machines not just by the fact that there is no human inside, but also by the fact that they carry sensors that gather information about the world around them, processors that use that information to make appropriate decisions, and effectors that act to create change in the world around the machine, such as by movement or firing a weapon. They do not merely remove the human from risk, changing our very concept of the role of a warrior, but in so doing reshape many of the foundational concepts of what war itself entails.";

    CoreDocument document = new CoreDocument(text);
    pipeline.annotate(document);
  }
}

@AngledLuffa AngledLuffa reopened this Dec 1, 2021
@amracel
Copy link

amracel commented Dec 1, 2021 •
edited
Loading

Sorry. Here's my code that calls it:

	public Annotation annotateDoc(String text) {
		Properties props = PropertiesUtils.asProperties("annotators",
				"tokenize,ssplit,pos,lemma,ner,depparse,coref,natlog,openie");
		StanfordCoreNLP pipeline = new StanfordCoreNLP(props);
		Annotation doc = new Annotation(text);
               pipeline.annotate(doc);
               return doc;
     }

I see that you use 'CoreDocument' instead of 'Annotation'. Would that make a difference?

@AngledLuffa
Copy link
Contributor

I'm still not able to trigger it. Are you certain this is version 4.3.2, with the text I just posted in my example? If you run that example, does it cause an error?

@amracel
Copy link

amracel commented Dec 2, 2021

OK - what worked was removing the 'ea' flag, as suggested in issue 804. But yes, I am running version 4.3.2.

@AngledLuffa
Copy link
Contributor

That's a pretty crap workaround. However, I can't figure out how to reproduce this issue. What I have done is put a more detailed exception into our dev branch:

106bae1

Are you able to rebuild the source tree including this change and retry the query which is causing you problems? I can also prepare an interim release if that would make it easier to run this. We really should figure out what's causing the error...

@AngledLuffa
Copy link
Contributor

I built a sample distribution to accommodate some other issues as well:

https://nlp.stanford.edu/software/stanford-corenlp-4.3.2b.zip

Would you try the text that was causing you problems, then report the error if it produces an error? I'd like to actually fix this rather than just ignore it

@amracel
Copy link

amracel commented Dec 7, 2021 •
edited
Loading

I took your jar and substituted it for the one I was using in my code and saw no difference when I readded the 'ea' flags. So, I tried to minimize the differences by adding the 'ea' flags to the corenlp.sh file:

#java -mx5g -cp "$scriptdir/*" edu.stanford.nlp.pipeline.StanfordCoreNLP $*
java -ea -mx5g -cp "$scriptdir/*" edu.stanford.nlp.pipeline.StanfordCoreNLP $*

I put my text into the input.txt file.

I then called it with the annotators I was trying to use:

./corenlp.sh -annotators tokenize,ssplit,pos,lemma,ner,depparse,coref,natlog,openie -file input.txt

I still got the same error.

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Dec 7, 2021 via email

@amracel
Copy link

amracel commented Dec 7, 2021

It doesn't seem to:

[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator tokenize
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator ssplit
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator pos
[main] INFO edu.stanford.nlp.tagger.maxent.MaxentTagger - Loading POS tagger from edu/stanford/nlp/models/pos-tagger/english-left3words-distsim.tagger ... done [0.6 sec].
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator lemma
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator ner
[main] INFO edu.stanford.nlp.ie.AbstractSequenceClassifier - Loading classifier from edu/stanford/nlp/models/ner/english.all.3class.distsim.crf.ser.gz ... done [1.1 sec].
[main] INFO edu.stanford.nlp.ie.AbstractSequenceClassifier - Loading classifier from edu/stanford/nlp/models/ner/english.muc.7class.distsim.crf.ser.gz ... done [0.4 sec].
[main] INFO edu.stanford.nlp.ie.AbstractSequenceClassifier - Loading classifier from edu/stanford/nlp/models/ner/english.conll.4class.distsim.crf.ser.gz ... done [0.4 sec].
[main] INFO edu.stanford.nlp.time.JollyDayHolidays - Initializing JollyDayHoliday for SUTime from classpath edu/stanford/nlp/models/sutime/jollyday/Holidays_sutime.xml as sutime.binder.1.
[main] INFO edu.stanford.nlp.time.TimeExpressionExtractorImpl - Using following SUTime rules: edu/stanford/nlp/models/sutime/defs.sutime.txt,edu/stanford/nlp/models/sutime/english.sutime.txt,edu/stanford/nlp/models/sutime/english.holidays.sutime.txt
[main] INFO edu.stanford.nlp.pipeline.TokensRegexNERAnnotator - ner.fine.regexner: Read 580705 unique entries out of 581864 from edu/stanford/nlp/models/kbp/english/gazetteers/regexner_caseless.tab, 0 TokensRegex patterns.
[main] INFO edu.stanford.nlp.pipeline.TokensRegexNERAnnotator - ner.fine.regexner: Read 4867 unique entries out of 4867 from edu/stanford/nlp/models/kbp/english/gazetteers/regexner_cased.tab, 0 TokensRegex patterns.
[main] INFO edu.stanford.nlp.pipeline.TokensRegexNERAnnotator - ner.fine.regexner: Read 585572 unique entries from 2 files
[main] INFO edu.stanford.nlp.pipeline.NERCombinerAnnotator - numeric classifiers: true; SUTime: true [no docDate]; fine grained: true
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator depparse
[main] INFO edu.stanford.nlp.parser.nndep.DependencyParser - Loading depparse model: edu/stanford/nlp/models/parser/nndep/english_UD.gz ... Time elapsed: 0.9 sec
[main] INFO edu.stanford.nlp.parser.nndep.Classifier - PreComputed 20000 vectors, elapsed Time: 1.133 sec
[main] INFO edu.stanford.nlp.parser.nndep.DependencyParser - Initializing dependency parser ... done [2.0 sec].
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator coref
[main] INFO edu.stanford.nlp.coref.statistical.SimpleLinearClassifier - Loading coref model edu/stanford/nlp/models/coref/statistical/ranking_model.ser.gz ... done [0.8 sec].
[main] INFO edu.stanford.nlp.pipeline.CorefMentionAnnotator - Using mention detector type: dependency
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator natlog
[main] INFO edu.stanford.nlp.pipeline.StanfordCoreNLP - Adding annotator openie
[main] INFO edu.stanford.nlp.naturalli.ClauseSplitter - Loading clause splitter from edu/stanford/nlp/models/naturalli/clauseSearcherModel.ser.gz ... done [0.027 seconds]

Processing file /Users/anneracel/Downloads/stanford-corenlp-4.3.2b/input.txt ... writing to /Users/anneracel/Downloads/stanford-corenlp-4.3.2b/input.txt.out
Exception in thread "main" java.lang.AssertionError
	at edu.stanford.nlp.naturalli.Util.cleanTree(Util.java:324)
	at edu.stanford.nlp.naturalli.OpenIE.annotateSentence(OpenIE.java:474)
	at edu.stanford.nlp.naturalli.OpenIE.lambda$annotate$2(OpenIE.java:558)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at edu.stanford.nlp.naturalli.OpenIE.annotate(OpenIE.java:558)
	at edu.stanford.nlp.pipeline.AnnotationPipeline.annotate(AnnotationPipeline.java:76)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:655)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:665)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.processFiles(StanfordCoreNLP.java:1263)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.processFiles(StanfordCoreNLP.java:1097)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.run(StanfordCoreNLP.java:1363)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.main(StanfordCoreNLP.java:1432)

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Dec 8, 2021 via email

@AngledLuffa
Copy link
Contributor

The jar not being updated was my mistake. A couple other changes were included, but not the new exception. If you're willing to try again, I updated the jar for sure this time. Or just sending us the input.txt you used to trigger the error would help, especially if it can be triggered just by running the StanfordCoreNLP main program.

@amracel
Copy link

amracel commented Dec 8, 2021

I emailed you the file I was using.

@AngledLuffa
Copy link
Contributor

Why can I not reproduce this no matter what I do? Aaaagh

I did this:

java edu.stanford.nlp.pipeline.StanfordCoreNLP -file input.txt -annotators "tokenize,ssplit,pos,lemma,ner,depparse,coref,natlog,openie"

I did this:

import java.util.*;
import edu.stanford.nlp.pipeline.*;
import edu.stanford.nlp.util.*;

class foo {
  public static Annotation annotateDoc(String text) {
    Properties props = PropertiesUtils.asProperties("annotators", "tokenize,ssplit,pos,lemma,ner,depparse,coref,natlog,openie");
    StanfordCoreNLP pipeline = new StanfordCoreNLP(props);
    Annotation doc = new Annotation(text);
    pipeline.annotate(doc);
    return doc;
  }

  public static void main(String[] args) {
    String text = "Unmanned systems are machines that operate under a 'sense,' 'think,' 'act' paradigm. That is, they are distinguished from regular machines not just by the fact that there is no human inside, but also by the fact that they carry sensors that gather information about the world around them, processors that use that information to make appropriate decisions, and effectors that act to create change in the world around the machine, such as by movement or firing a weapon. They do not merely remove the human from risk, changing our very concept of the role of a warrior, but in so doing reshape many of the foundational concepts of what war itself entails.";
    annotateDoc(text);
  }
}

with ' and with the weird angle quotes. Nothing triggers the error.

Dumb question maybe, are you sure the models you're using are the ones that ship with the latest release? Or perhaps the "beta" release I sent you a couple days ago? I updated the beta release so that contains the more detailed error message:

https://nlp.stanford.edu/software/stanford-corenlp-4.3.2b.zip

@AngledLuffa
Copy link
Contributor

What JDK and platform are you using, btw? Not sure I'll be able to recreate exact conditions, and hopefully the results don't actually change across platforms anyway...

@AngledLuffa
Copy link
Contributor

Honestly I don't know why it's using EnhancedPlusPlus dependencies when it's insisting that the graph be a tree, which is simply not necessarily the case for EPP as far as I know

@AngledLuffa
Copy link
Contributor

Ah crud, I just realized my extra debugging code was applied to stripPrepCases, which isn't even called anywhere in the code that I see. I hate this particular annotator so much

@AngledLuffa
Copy link
Contributor

Oh thank goodness. I can finally reproduce the error. Sorry for the wasted time :/

@amracel
Copy link

amracel commented Dec 9, 2021

Operating environment: Macbook Pro running macOS Monterey, version 12.0.1
Java version:

openjdk 16.0.1 2021-04-20
OpenJDK Runtime Environment Homebrew (build 16.0.1+0)
OpenJDK 64-Bit Server VM Homebrew (build 16.0.1+0, mixed mode, sharing)

@AngledLuffa AngledLuffa mentioned this issue Dec 9, 2021
Merged
@AngledLuffa
Copy link
Contributor

Alright, something went wrong with our unit tests, which I need to figure out. However, I updated the above link to not crash on this specific sentence, at least. How do you feel about being a guinea pig?

@amracel
Copy link

amracel commented Dec 10, 2021

Oink oink?

I don't mind.

@AngledLuffa
Copy link
Contributor

That's a different kind of pig!

The fix should be here:

https://nlp.stanford.edu/software/stanford-corenlp-4.3.2b.zip

@AngledLuffa AngledLuffa mentioned this issue Dec 11, 2021
Closed
@amracel
Copy link

amracel commented Dec 14, 2021

Huzzah! That worked!

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Dec 14, 2021 via email

@AngledLuffa
Copy link
Contributor

4.4.0 now released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manzurola @AngledLuffa @amracel