Fix c++-mode interference #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Need this to run some tests before stan-mode loading
- The old :override version was calling the original function c-syntactic-end-of-macro by name inside its body conditionally. - This should be an :around advice that conditionally calls the oldfun, which is given as the argument.
- It relies on advice-member-p detecting stan-syntactic-end-of-macro.
- Fix interference with c++-mode stan-dev#64
|
All github action checks passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
In the previous version, invocation of
stan-modevia loading a stan file advisedc-syntactic-end-of-macroincorrectly, making it malfunction inc++-mode. This resulted in broken syntax highlighting in a C++ file.This interference issue was solved by improving the advising of
c-syntactic-end-of-macro.Also github actions were adopted for testing (magit/magit#4303).