Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call make_stan_functions() #128

Closed
wants to merge 2 commits into from
Closed

Conversation

bgoodri
Copy link

@bgoodri bgoodri commented Jan 13, 2020

Submission Checklist

  • Builds locally (but needs to fix merge conflicts)
  • Declare copyright holder and open-source license: see below

Summary

This PR defines and calls a make_stan_functions Python function to (re)create the stan-functions.txt file that is used by

https://github.com/stan-dev/rstan/blob/develop/rstan/rstan/tools/stan-functions.txt

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Trustees of Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris
Copy link
Member

@bgoodri - thanks for sharing your code.
this should be implemented as a stand-alone python program, not as part of build.py. I would be willing to do this for you.

@bgoodri
Copy link
Author

bgoodri commented Jan 13, 2020 via email

kaz-yos added a commit to kaz-yos/stan-language-definitions that referenced this pull request Feb 12, 2020
As of now, rstan is still using stan 2.19.
"But we haven’t been able to get rstan beyond the Stan 2.19 branch, no so much due to stanc3 but due to the CRTP and some non-deterministic compiler behavior."
https://discourse.mc-stan.org/t/cmdstanr-and-rstudio-stan-syntax-highlighting/13072/6

The automatic generation of stan-functions.txt from the latest stan requires the following be merged.
stan-dev/docs#128
@kaz-yos
Copy link
Contributor

kaz-yos commented Feb 17, 2020

The Emacs stan-mode (https://github.com/stan-dev/stan-mode) heavily relies on the stan-functions.txt file. So if it can keep up with the latest Stan automatically, that will be great!

@mitzimorris
Copy link
Member

closing this - will be implemented as part of #180

@WardBrian WardBrian deleted the feature/make_stan_functions2 branch March 23, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants