Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate python 3.8, add testing of python 3.12 #64

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philvarner
Copy link

Related Issue(s):

n/a

Description:

  1. Restrict to require Python >=3.9 (previously unrestricted)
  2. Test Python 3.12 in CI

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG.

@philvarner
Copy link
Author

Putting this back into draft mode as the latest aiohttp release doesn't build correctly on 3.12.

aiohttp can either (1) be pinned to aiohttp==3.9.0b0 or (2) AIOHTTP_NO_EXTENSIONS=1 set for the install (per aio-libs/aiohttp#7229)

@philvarner philvarner marked this pull request as ready for review November 13, 2023 20:08
Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could pygrade a-la pystac: stac-utils/pystac#1261.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants