Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTL Text representation parsing #58

Merged
merged 8 commits into from
Aug 21, 2023

Conversation

constantinius
Copy link
Contributor

This PR allows the reading of MTL text files instead of MTL XML or JSON.

This is necessary in some cases when XML files are absent (like in some collections on CREODIAS).

The create_stac function now tries the text based MTL parsing if the filename ends with .txt. This could also be behind a switch.

Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested refactor, and it looks like linting needs some TLC as well. You can run pre-commit run --all-files before pushing to ensure that CI should be happy at least w.r.t. lints.

src/stactools/landsat/stac.py Outdated Show resolved Hide resolved
@constantinius
Copy link
Contributor Author

@gadomski I fixed the issues you stated. Could you have another look?

@gadomski gadomski self-requested a review August 21, 2023 12:49
Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but CI's saying that some tests need fixing.

@constantinius
Copy link
Contributor Author

Ah, sorry! Test is fixed now.

@gadomski gadomski self-requested a review August 21, 2023 16:41
@gadomski gadomski merged commit b842e9c into stactools-packages:main Aug 21, 2023
5 checks passed
@constantinius constantinius deleted the mtl-text branch August 28, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants