-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTL Text representation parsing #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One requested refactor, and it looks like linting needs some TLC as well. You can run pre-commit run --all-files
before pushing to ensure that CI should be happy at least w.r.t. lints.
@gadomski I fixed the issues you stated. Could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but CI's saying that some tests need fixing.
Ah, sorry! Test is fixed now. |
This PR allows the reading of MTL text files instead of MTL XML or JSON.
This is necessary in some cases when XML files are absent (like in some collections on CREODIAS).
The
create_stac
function now tries the text based MTL parsing if the filename ends with.txt
. This could also be behind a switch.