Skip to content

Commit

Permalink
refactor(angular): move app tsconfig up a level to match CLI output. (#…
Browse files Browse the repository at this point in the history
…28)

* refactor(angular): move app tsconfig up a level to match CLI output.

This also fixes `ng add @angular/ssr` setup.

* chore: update Angular to 17.2

Note: piscina is overridded because version 4.3.0 relies on the histogram API which isn't fully supported by Webcontainers.
  • Loading branch information
JeanMeche authored Feb 26, 2024
1 parent fd1591a commit 1caa18e
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 20 deletions.
2 changes: 1 addition & 1 deletion angular/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"outputPath": "dist/demo",
"scripts": [],
"styles": ["src/global_styles.css"],
"tsConfig": "src/tsconfig.app.json"
"tsConfig": "tsconfig.app.json"
}
},
"serve": {
Expand Down
25 changes: 15 additions & 10 deletions angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,26 @@
"build": "ng build"
},
"dependencies": {
"@angular/animations": "~17.1.0",
"@angular/common": "~17.1.0",
"@angular/compiler": "~17.1.0",
"@angular/core": "~17.1.0",
"@angular/forms": "~17.1.0",
"@angular/platform-browser": "~17.1.0",
"@angular/router": "~17.1.0",
"@angular/animations": "^17.2.0",
"@angular/common": "^17.2.0",
"@angular/compiler": "^17.2.0",
"@angular/core": "^17.2.0",
"@angular/forms": "^17.2.0",
"@angular/platform-browser": "^17.2.0",
"@angular/router": "^17.2.0",
"rxjs": "^7.8.1",
"tslib": "^2.5.0",
"zone.js": "~0.14.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "~17.1.0",
"@angular/cli": "~17.1.0",
"@angular/compiler-cli": "~17.1.0",
"@angular-devkit/build-angular": "^17.2.0",
"@angular/cli": "^17.2.0",
"@angular/compiler-cli": "^17.2.0",
"typescript": "~5.3.0"
},
"overrides": {
"@angular-devkit/build-angular": {
"piscina": "~4.2.0"
}
}
}
9 changes: 0 additions & 9 deletions angular/src/tsconfig.app.json

This file was deleted.

10 changes: 10 additions & 0 deletions angular/tsconfig.app.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
{
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "./out-tsc/app",
"types": []
},
"files": ["src/main.ts"],
"include": ["src/**/*.d.ts"]
}

0 comments on commit 1caa18e

Please sign in to comment.