Let secret-operator handle PKCS#12 conversion #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # Cargo.lock
razvan
reviewed
Jun 30, 2023
There was a problem hiding this comment.
I get this when running the smoke test with tls enabled everywhere:
Caused by: java.io.FileNotFoundException: /stackable/server_tls/keystore.p12 (No such file or directory) │
│ at java.base/java.io.FileInputStream.open0(Native Method) │
│ at java.base/java.io.FileInputStream.open(FileInputStream.java:219) │
│ at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157) │
│ at org.apache.zookeeper.common.StandardTypeFileKeyStoreLoader.loadKeyStore(StandardTypeFileKeyStoreLoader.java:53) │
│ at org.apache.zookeeper.common.X509Util.loadKeyStore(X509Util.java:410) │
│ at org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:466) │
│ ... 27 common frames omitted
|
Are you sure that 1) you're running a trunk build of secret-op, and 2) that your secret-op is new enough to include the PR? |
razvan
reviewed
Jun 30, 2023
|
Ping @nightkr I think this can be updated with the latest operator-rs version. I'd quickly review again and approve. |
razvan
previously approved these changes
Aug 2, 2023
razvan
approved these changes
Aug 3, 2023
|
🥳 |
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires stackabletech/secret-operator#286 and stackabletech/operator-rs#610
Definition of Done Checklist
Author
Reviewer
Acceptance
Once the review is done, comment
bors r+(orbors merge) to merge. Further information