Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support PodDisruptionBudgets #481

Merged
merged 10 commits into from
Oct 6, 2023
Merged

feat: Support PodDisruptionBudgets #481

merged 10 commits into from
Oct 6, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 29, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@sbernauer sbernauer mentioned this pull request Sep 29, 2023
Closed
@sbernauer
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/101/

@sbernauer sbernauer self-assigned this Sep 29, 2023
@sbernauer
Copy link
Member Author

Retry https://ci.stackable.tech/job/trino-operator-it-custom/102/

@sbernauer sbernauer requested review from adwk67 and removed request for maltesander October 5, 2023 14:20
maltesander
maltesander requested changes Oct 5, 2023
View reviewed changes
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/trino/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
sbernauer and others added 3 commits October 5, 2023 16:25
@sbernauer @maltesander
Update docs/modules/trino/pages/usage-guide/operations/pod-disruption…
6d31346 
…s.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer @maltesander
Apply suggestions from code review
e8be4e5 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer
Merge branch 'main' into feat/support-pdb
4a97317
maltesander
maltesander approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 32f4aec Oct 6, 2023
30 checks passed
@sbernauer sbernauer deleted the feat/support-pdb branch October 6, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@adwk67 adwk67 Awaiting requested review from adwk67

Assignees

@sbernauer sbernauer

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @maltesander @lfrancke