Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use new Duration struct from operator-rs #474

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 18, 2023

Description

Part of stackabletech/operator-rs#649

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

nightkr
nightkr previously approved these changes Sep 18, 2023
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sbernauer sbernauer added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit fee4c76 Sep 19, 2023
30 checks passed
@sbernauer sbernauer deleted the refactor/duration-format branch September 19, 2023 13:37
@lfrancke
Copy link
Member

Is this a CRD change?
Please complete the checklists

@sbernauer
Copy link
Member Author

yes (but within the 0.0.0-dev version, so no breaking change), checked them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants