Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Removed tools image for init container #357

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ All notable changes to this project will be documented in this file.
- LDAP integration tests create all resources in their namespace and not some in the default namespace ([#344]).
- Don't run init container as root and avoid chmod and chowning ([#353]).
- [BREAKING] Use Product image selection instead of version. `spec.version` has been replaced by `spec.image` ([#356]).
- [BREAKING]: Removed tools image for init container and replaced with Trino product image. This means the latest stackable version has to be used in the product image selection ([#357])

### Fixed

Expand All @@ -28,6 +29,7 @@ All notable changes to this project will be documented in this file.
[#348]: https://github.com/stackabletech/trino-operator/pull/348
[#353]: https://github.com/stackabletech/trino-operator/pull/353
[#356]: https://github.com/stackabletech/trino-operator/pull/356
[#357]: https://github.com/stackabletech/trino-operator/pull/357

## [0.8.0] - 2022-11-07

Expand Down
2 changes: 1 addition & 1 deletion docs/modules/getting_started/examples/code/trino.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector:
matchLabels:
trino: simple-trino
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector: {}
authentication:
method:
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/usage_guide/examples/code/trino-insecure.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector:
matchLabels:
trino: simple-trino
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector: {}
authentication:
method:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
config:
internalTls:
secretClass: trino-internal-tls # <1>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
config:
tls:
secretClass: trino-tls # <1>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
config:
tls:
secretClass: trino-tls # <1>
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/usage_guide/pages/catalogs/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector:
matchLabels:
trino: simple-trino
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
opa:
configMapName: simple-opa
package: trino
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-trino-cluster-hive-ha-s3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector:
matchLabels:
trino: simple-trino
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-trino-cluster-resource-limits.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector: {}
coordinators:
roleGroups:
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-trino-cluster-s3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector:
matchLabels:
trino: simple-trino
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-trino-cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
spec:
image:
productVersion: 396
stackableVersion: 0.2.0
stackableVersion: 0.3.0
catalogLabelSelector:
matchLabels:
trino: simple-trino
Expand Down
2 changes: 1 addition & 1 deletion rust/operator-binary/src/controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ fn build_rolegroup_statefulset(
)?;

let container_prepare = cb_prepare
.image("docker.stackable.tech/stackable/tools:0.2.0-stackable0.4.0")
.image_from_product_image(resolved_product_image)
.command(vec!["/bin/bash".to_string(), "-c".to_string()])
.args(command::container_prepare_args(trino, catalogs))
.add_volume_mount("data", DATA_DIR_NAME)
Expand Down
10 changes: 5 additions & 5 deletions tests/test-definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
dimensions:
- name: trino
values:
- 377-stackable0.2.0
- 387-stackable0.2.0
- 395-stackable0.2.0
- 396-stackable0.2.0
- 377-stackable0.3.0
- 387-stackable0.3.0
- 395-stackable0.3.0
- 396-stackable0.3.0
- name: trino-latest
values:
- 396-stackable0.2.0
- 396-stackable0.3.0
- name: hive
values:
- 2.3.9-stackable0.6.0
Expand Down