Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add support for TPCH connector and TPCDS connector #293

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add support for TPCH connector and TPCDS connector #293

wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

Description

Needed for research of demo datasets

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from a team September 20, 2022 08:52
maltesander
maltesander reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to document this?

@sbernauer
Copy link
Member Author

Yes, missed that. Added them to the list of supported connectors. Not much to document for them ^^

maltesander
maltesander approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maltesander maltesander mentioned this pull request Sep 20, 2022
Closed
2 tasks
@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 20, 2022
@sbernauer
Add support for TPCH connector and TPCDS connector (#293)
085786d 
# Description

Needed for research of demo datasets
@bors
Copy link
Contributor

bors bot commented Sep 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add support for TPCH connector and TPCDS connector [Merged by Bors] - Add support for TPCH connector and TPCDS connector Sep 20, 2022
@bors bors bot closed this Sep 20, 2022
@bors bors bot deleted the hpc-connectors branch September 20, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander