-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Re-structure/expand Trino catalog documentation #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
requested review from
sbernauer
and removed request for
maltesander
September 20, 2022 14:20
sbernauer
reviewed
Sep 20, 2022
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
fhennig
requested changes
Sep 21, 2022
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
fhennig
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(still some improvements required to the overall structure, but not in the scope of this ticket)
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
# Description - Adds a concept page for catalog usage - splits the usage page into a series of pages under "Usage guide" - attempts to make each cluster/TLS scenario self-enclosed and runnable Closes #274.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Re-structure/expand Trino catalog documentation
[Merged by Bors] - Re-structure/expand Trino catalog documentation
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #274.
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information