Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement resource requests and limits for Trino pods #270

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Implement resource requests and limits for Trino pods #270

wants to merge 9 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 5, 2022 •
edited
Loading

Description

  • PVC, memory and CPU requests and limits now configurable
  • added new integration tests folder "resources"

closes #248

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team September 5, 2022 14:13
@maltesander maltesander self-assigned this Sep 5, 2022
@maltesander maltesander added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 5, 2022
@maltesander maltesander marked this pull request as ready for review September 5, 2022 15:21
@sbernauer sbernauer self-assigned this Sep 6, 2022
sbernauer
sbernauer reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments

docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
@sbernauer
Copy link
Member

sbernauer commented Sep 6, 2022 •
edited
Loading

In https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/18/consoleFull we have test failure such as
case.go:363: resource PersistentVolumeClaim:kuttl-test-free-pheasant/data-trino-coordinator-resources-default-0: .spec.resources.requests.storage: value mismatch, expected: 2Gi != actual: 1Gi

@sbernauer
Copy link
Member

Ahh you did make a small mistake when triggering your custom test: You have to pick the 0.5.0-pr270 version of the Trino operator, not just the current nightly (bear in mind to wait that the github action building your 0.5.0-pr270 image + helm-chart has finished before starting the tests)
Re-triggered it with your pr version: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/19/console

@maltesander
Copy link
Member Author

Ahh you did make a small mistake when triggering your custom test: You have to pick the 0.5.0-pr270 version of the Trino operator, not just the current nightly (bear in mind to wait that the github action building your 0.5.0-pr270 image + helm-chart has finished before starting the tests) Re-triggered it with your pr version: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/19/console

Ah damn thanks, that wasnt the smartest move then ;)

sbernauer
sbernauer approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/19/console succeeds

@sbernauer
Copy link
Member

All resources test already have passed 🥳

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 6, 2022
@maltesander
Implement resource requests and limits for Trino pods (#270)
a9898bb 
# Description

- PVC, memory and CPU requests and limits now configurable
- added new integration tests folder "resources"

closes #248



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement resource requests and limits for Trino pods [Merged by Bors] - Implement resource requests and limits for Trino pods Sep 6, 2022
@bors bors bot closed this Sep 6, 2022
@bors bors bot deleted the resource_limits branch September 6, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

@sbernauer sbernauer

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement resource requests and limits for Trino pods
2 participants
@maltesander @sbernauer