Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templated files to rev efb48ae #483

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
Expand All @@ -22,7 +22,7 @@
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
```
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,13 @@
make -e build
- name: Publish Docker image and Helm chart
if: ${{ !github.event.pull_request.head.repo.fork }}
run: make -e publish
run: |

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1009:info:2:1: The mentioned syntax error was in this if expression [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1009:info:2:1: The mentioned syntax error was in this if expression [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1035:error:2:4: You need a space after the [ and before the ] [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1035:error:2:4: You need a space after the [ and before the ] [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1073:error:2:4: Couldn't parse this test expression. Fix to allow more checks [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1073:error:2:4: Couldn't parse this test expression. Fix to allow more checks [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1020:error:2:30: You need a space before the ] [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1020:error:2:30: You need a space before the ] [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1072:error:2:30: Missing space before ]. Fix any mentioned problems and try again [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1072:error:2:30: Missing space before ]. Fix any mentioned problems and try again [shellcheck]
# We want to publish helmcharts only once as they have a common name, while still publishing both images with architecture specific tags
if ["$(uname -m)" = "x86_64"]; then
make -e publish
else
make -e docker-publish
fi
# Output the name of the published image to the Job output for later use
- id: printtag
name: Output image name and tag
Expand Down
Loading