Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AD samAccountName generation to be customized #454

Merged
merged 14 commits into from
Jul 29, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 28, 2024

Description

Fixes #449

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr marked this pull request as ready for review July 22, 2024 15:04
@nightkr nightkr requested a review from a team July 22, 2024 15:04
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks very good overall! Just some small comments

docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
rust/krb5-provision-keytab/src/active_directory.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/crd.rs Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
rust/operator-binary/src/crd.rs Show resolved Hide resolved
@nightkr nightkr requested a review from sbernauer July 26, 2024 14:08
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, looks good now!

@nightkr nightkr added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 38e508b Jul 29, 2024
31 checks passed
@nightkr nightkr deleted the feature/samaccountname-rules branch July 29, 2024 11:09
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-request release/2024-11 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
4 participants