Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to installing the TLS CA into the operator's target namespace #397

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Apr 8, 2024

Description

See stackabletech/issues#498. OLM manifests are generated from the Helm charts, so fixing it in one should fix it in the other.

Note that this is a breaking change, existing users will need to either --set secretClasses.tls.caSecretNamespace=default or copy their CA secret across (kubectl -n default get secret/secret-provisioner-tls-ca -o json | jq '.metadata.namespace = "stackable-operators"' | kubectl create -f-).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr requested a review from a team April 8, 2024 13:48
@nightkr nightkr self-assigned this Apr 8, 2024
@nightkr nightkr marked this pull request as ready for review April 8, 2024 13:48
@razvan
Copy link
Member

razvan commented Apr 8, 2024

This prompted me to have a look at what we've done with 24.3 and it looks like default is hard coded there too.

Then I generated the manifests from this branch and saw that "default" is also used. This is understandable because there is no namespace set at the time when we generated the manifests.

So I think that this is a good fix for Helm but not for OLM where we probably need to interpolate the namespace from the environment at the installation time (or something like that).

I added a new task to this epic: stackabletech/issues#561

@nightkr
Copy link
Member Author

nightkr commented Apr 12, 2024

This is still going to leave us in a better spot for OLM too though than we were in before, right? At least it would align with the default settings.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but maybe remove the Fixes reference to the issue before merging so that it's not closed automatically.

@nightkr nightkr added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 5af1414 Apr 12, 2024
29 of 30 checks passed
@nightkr nightkr deleted the bugfix/tls-ca-ns branch April 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants