Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CA lifetimes configurable #357

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 30, 2024

Description

Fixes #354

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr requested a review from a team January 30, 2024 15:59
@sbernauer sbernauer self-requested a review January 31, 2024 07:48
Copy link
Member

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some docs to this page? https://docs.stackable.tech/home/nightly/secret-operator/secretclass#backend-autotls

maybe the property could be lifetime instead of caLifetime since it's under the ca key already (sorry for the bikeshedding 😬 )

other than that, looks good to me 👍

@nightkr
Copy link
Member Author

nightkr commented Jan 31, 2024

Added docs, updated to align with the CRD review.

@nightkr nightkr requested a review from fhennig January 31, 2024 11:27
@soenkeliebau
Copy link
Member

This doesn't yet reflect the updated default CA duration of one year, right?
Should we make that change in here, or later on in a subsequent PR?

fhennig
fhennig previously approved these changes Jan 31, 2024
Copy link
Member

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

regarding the 2y default in default_ca_certificate_lifetime I think it might be easiest to update it in here still. I can re-approve if you sitll want to change this @nightkr

If this change is not made here we need to make a ticket for it so we do not forget about it later

@sbernauer
Copy link
Member

The ticket we discussed in Arch meeting is #358 ;)

@fhennig
Copy link
Member

fhennig commented Jan 31, 2024

Alright so yeah fine either way, do it here and close #358 too or not 🆗

@nightkr
Copy link
Member Author

nightkr commented Jan 31, 2024

I think either is fine, I'd personally do it in a separate PR and changelog entry.

Copy link
Member

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: unresolved link to `Self::ca_lifetime`
   --> rust/operator-binary/src/backend/tls/ca.rs:154:28
    |
154 |     /// and smaller than [`Self::ca_lifetime`].
    |                            ^^^^^^^^^^^^^^^^^ the struct `Config` has no field or associated item named `ca_lifetime`
    |
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

error: could not document `stackable-secret-operator`

@nightkr
Copy link
Member Author

nightkr commented Feb 1, 2024

Argh, you're right. Should be fixed now..

@nightkr nightkr requested a review from fhennig February 1, 2024 10:45
Copy link
Member

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nightkr nightkr added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit f5bdbe3 Feb 1, 2024
30 checks passed
@nightkr nightkr deleted the feature/configure-ca-lifetime branch February 1, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring CA certificate lifetime
4 participants