Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encrypting PKCS#12 stores with a password #314

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Sep 6, 2023

Description

Fixes #313.

We add a new volume parameter secrets.stackable.tech/format.compatibility.tls-pkcs12.password for controlling this. The password should not be considered private (PVC manifests are generally public!), this is purely for compatibility with certain broken apps.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr requested review from maltesander and a team September 6, 2023 14:48
@nightkr nightkr self-assigned this Sep 6, 2023
@nightkr
Copy link
Member Author

nightkr commented Sep 6, 2023

I'm not sure if this is something that we want to document, since this is more of a desperate "feature of last resort".

maltesander
maltesander previously approved these changes Sep 7, 2023
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lets wait what the arch meeting brings.

rust/operator-binary/src/backend/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general okay after the comment for compat_tls_pkcs12_password is fixed.

I would not emphasize it so much that the password is used for compatibility reasons. It is an option (and not a compatibility option) which is used for compatibility and not too useful on its own.

@nightkr
Copy link
Member Author

nightkr commented Sep 7, 2023

It only exists for compatibility, and provides no useful security improvement on its own.

I absolutely want to avoid misleading people around this...

Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit f4fd0c5 Sep 12, 2023
30 checks passed
@nightkr nightkr deleted the feature/pkcs12-password branch September 12, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to override PKCS#12 password
4 participants