Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make cert lifetime configurable #306

Merged
merged 35 commits into from
Oct 25, 2023
Merged

feat: Make cert lifetime configurable #306

merged 35 commits into from
Oct 25, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 25, 2023 •
edited
Loading

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

nightkr
nightkr reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a comprehensive review, just going over the initial numbers so far...

rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
deploy/helm/secret-operator/crds/crds.yaml Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

@nightkr thanks for the review, ready for review again

@sbernauer sbernauer mentioned this pull request Sep 14, 2023
Closed
@sbernauer sbernauer self-assigned this Sep 15, 2023
@sbernauer sbernauer force-pushed the feat/make-cert-lifetime-configurable branch from 9f9ef02 to a4150de Compare September 21, 2023 06:45
@sbernauer sbernauer force-pushed the feat/make-cert-lifetime-configurable branch from a4150de to c1f4558 Compare September 21, 2023 06:46
sbernauer
sbernauer commented Sep 21, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

@nightkr adjusted the PR to the Arch meeting decisions and the new Duration struct.
A review would be great!

@sbernauer sbernauer requested review from nightkr and removed request for nightkr September 21, 2023 08:49
github-actions[bot]
github-actions bot reviewed Sep 27, 2023
View reviewed changes
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer mentioned this pull request Oct 9, 2023
Merged
@sbernauer
Copy link
Member Author

@nightkr unblocked and ready for review
Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/secret-operator-it-custom/7/

Techassi
Techassi requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments.

docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/volume.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/volume.adoc Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/mod.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/tls.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/crd.rs Show resolved Hide resolved
@sbernauer
Copy link
Member Author

Thanks for the reviews!

@sbernauer sbernauer added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 311f6b1 Oct 25, 2023
30 checks passed
@sbernauer sbernauer deleted the feat/make-cert-lifetime-configurable branch October 25, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@Techassi Techassi Techassi approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @nightkr @Techassi