Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Complete example for how k8sSearch works #278

Closed
wants to merge 4 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 1, 2023

Fixes #273

@razvan razvan requested a review from a team June 1, 2023 09:59
@sbernauer sbernauer self-requested a review June 2, 2023 06:34
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! LGTM % comments

docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Outdated Show resolved Hide resolved
razvan and others added 3 commits June 2, 2023 11:12
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
Copy link
Member Author

razvan commented Jun 2, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 2, 2023
@bors
Copy link
Contributor

bors bot commented Jun 2, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Complete example for how k8sSearch works [Merged by Bors] - Complete example for how k8sSearch works Jun 2, 2023
@bors bors bot closed this Jun 2, 2023
@bors bors bot deleted the docs/secret-class-label branch June 2, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that k8sSearch secrets must be labeled with the secretclass
2 participants