Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: Add automatic CSI registration path migration 23.1 -> 23.4 #258

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - fix: Add automatic CSI registration path migration 23.1 -> 23.4 #258

wants to merge 5 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 30, 2023 •
edited
Loading

Description

Fixes #251

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer force-pushed the fix/migrate-csi-registration-path branch from a0d5358 to f2f795d Compare March 30, 2023 07:56
@sbernauer sbernauer force-pushed the fix/migrate-csi-registration-path branch from f2f795d to aecd13c Compare March 30, 2023 07:57
nightkr
nightkr reviewed Mar 30, 2023
View reviewed changes
deploy/helm/secret-operator/templates/daemonset.yaml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sbernauer sbernauer force-pushed the fix/migrate-csi-registration-path branch from 2f348d7 to 99769d4 Compare March 30, 2023 08:15
@nightkr
Copy link
Member

nightkr commented Mar 30, 2023

Please don't force-push PRs, it makes subsequent reviews a pain.

nightkr
nightkr reviewed Mar 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sbernauer @nightkr
Update CHANGELOG.md
5bf0ae4 
Co-authored-by: Natalie <teo@nullable.se>
@sbernauer @nightkr
Update deploy/helm/secret-operator/templates/daemonset.yaml
7476ac6 
Co-authored-by: Natalie <teo@nullable.se>
nightkr
nightkr approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine in my testing cluster

@sbernauer
Copy link
Member Author

bors r+
Awesome, thx

bors bot pushed a commit that referenced this pull request Mar 30, 2023
@sbernauer
fix: Add automatic CSI registration path migration 23.1 -> 23.4 (#258)
d21476a 
# Description

Fixes #251
@bors
Copy link
Contributor

bors bot commented Mar 30, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix: Add automatic CSI registration path migration 23.1 -> 23.4 [Merged by Bors] - fix: Add automatic CSI registration path migration 23.1 -> 23.4 Mar 30, 2023
@bors bors bot closed this Mar 30, 2023
@bors bors bot deleted the fix/migrate-csi-registration-path branch March 30, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

@fhennig fhennig Awaiting requested review from fhennig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide automatic migration 23.1 -> 23.4
2 participants
@sbernauer @nightkr