Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement unprivileged mode #252

Closed
wants to merge 5 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 15, 2023

Description

This adds support for running as an unprivileged container (mostly fixes #243).

Sadly, it doesn't run rootless per se, since we need those privileges to register the CSI plugins, but it at least lets containerd/k8s keep some of its sandboxing.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from a team March 15, 2023 14:05
@nightkr
Copy link
Member Author

nightkr commented Mar 22, 2023

It has been ok'd by @lfrancke, so ready for review.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using helm install secret-operator stackable-test/secret-operator --version 0.0.0-pr252 --set securityContext.privileged=false

@nightkr
Copy link
Member Author

nightkr commented Mar 27, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 27, 2023
# Description

This adds support for running as an unprivileged container (mostly fixes #243).

Sadly, it doesn't run rootless per se, since we need those privileges to register the CSI plugins, but it at least lets containerd/k8s keep some of its sandboxing.
@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

Pull request successfully merged into main.

Build succeeded:

  • All tests passed

@bors bors bot changed the title Implement unprivileged mode [Merged by Bors] - Implement unprivileged mode Mar 27, 2023
@bors bors bot closed this Mar 27, 2023
@bors bors bot deleted the feature/unprivileged branch March 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support running in rootless mode
2 participants