Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove secretLabels option from k8sSearch backend #123

Closed
wants to merge 2 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented May 4, 2022

Description

This never had any real purpose, since we always add the name of the SecretClass as a required label anyway.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr self-assigned this May 4, 2022
@nightkr nightkr requested a review from a team May 4, 2022 15:04
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Out of curiosity: What's the reason for removing the label selector?

@sbernauer
Copy link
Member

Did you check that no examples for products or integration-tests use this attribute?

@nightkr
Copy link
Member Author

nightkr commented May 5, 2022

Out of curiosity: What's the reason for removing the label selector?

It's completely redundant, since the name of the secretclass must be specified on the secrets anyway, preventing any kind of overlap.

Did you check that no examples for products or integration-tests use this attribute?

I looked through the secret-op repo itself, but haven't searched downstream.

@nightkr
Copy link
Member Author

nightkr commented May 5, 2022

https://github.com/search?q=org%3Astackabletech+secretLabels&type=code only finds matches within the secret-op repo itself.

@nightkr
Copy link
Member Author

nightkr commented May 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request May 5, 2022
## Description

This never had any real purpose, since we always add the name of the `SecretClass` as a required label anyway.
@bors
Copy link
Contributor

bors bot commented May 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove secretLabels option from k8sSearch backend [Merged by Bors] - Remove secretLabels option from k8sSearch backend May 5, 2022
@bors bors bot closed this May 5, 2022
@bors bors bot deleted the antifeature/k8ssearch-secretlabels branch May 5, 2022 07:58
@sbernauer
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants