Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustfmt.toml to configure formatter #136

Merged
merged 1 commit into from
May 13, 2022
Merged

Add rustfmt.toml to configure formatter #136

merged 1 commit into from
May 13, 2022

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented May 10, 2022

Merge this after stackabletech/secret-operator#125 get's merged and didn't case any problems
I had a quick chat with @soenkeliebau and we agreed to give it a try

@soenkeliebau
Copy link
Member

The "issue" with this is, that it requires the unstable toolchain to work, so we won't introduce any checks around this, the file is purely there as an offer, if you want to use it in your operator then that is fine and this way we ensure that is is configured the same everywhere, but if you don't feel like switching to the nightly chain to run this then that is fine too.

@nightkr
Copy link
Member

nightkr commented May 10, 2022

For what it's worth, you can run a single cargo command using the nightly toolchain by using cargo +nightly fmt.

Rust-Analyzer should also allow you to set rustfmt-specific flags (for Emacs, put (setq rust-rustfmt-switches '("+nightly" "--edition" "2018")) into your .emacs), and I assume Rust-IntelliJ has something similar.

@sbernauer
Copy link
Member Author

Let's try that out

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request May 13, 2022
Merge this after stackabletech/secret-operator#125 get's merged and didn't case any problems
I had a quick chat with @soenkeliebau and we agreed to give it a try
@sbernauer sbernauer merged commit 8d0d186 into main May 13, 2022
@sbernauer sbernauer deleted the cargo-fmt branch May 13, 2022 07:29
@bors
Copy link

bors bot commented May 13, 2022

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants