fix(generate_pr): Don't use @ mention for --review option in gh CLI (#…

…437)

* fix(generate_prs): Remove @ from author, and only add it in the PR description.

* fix(generate_prs): Use a valid author for scheduled run as it will be used as the PR reviewer.

.github/workflows/generate_prs.yml

@@ -128,12 +128,12 @@ jobs:
       - name: Set commit message for manual dispatch
         if: ${{ github.event_name == 'workflow_dispatch' }}
         run: |
-          echo "AUTHOR=@${{ github.event.sender.login }}" >> "$GITHUB_ENV"
+          echo "AUTHOR=${{ github.event.sender.login }}" >> "$GITHUB_ENV"
           echo "REASON=${{ github.event.inputs.message }}" >> "$GITHUB_ENV"
       - name: Set commit message for schedule
         if: ${{ github.event_name == 'schedule' }}
         run: |
-          echo "AUTHOR=Github Actions"
+          echo "AUTHOR=stackabletech/developers"
           echo "REASON=Daily run triggered" >> "$GITHUB_ENV"
 
       - name: Overwrite repositories.yaml for ${{ matrix.repository.name }}
@@ -152,7 +152,7 @@ jobs:
         if: ${{ !inputs.dry-run }}
         run: |
           # Funnel via JSON to ensure that values are escaped properly
-          echo '{}' | jq '{commit_hash: $ENV.GITHUB_SHA, author: $ENV.AUTHOR, reason: $ENV.REASON, base_dir: $pwd,  gh_access_token: $ENV.GH_ACCESS_TOKEN}' --arg pwd "$(pwd)" > vars.json
+          echo '{}' | jq '{commit_hash: $ENV.GITHUB_SHA, author: $ENV.AUTHOR, reason: $ENV.REASON, base_dir: $pwd, gh_access_token: $ENV.GH_ACCESS_TOKEN}' --arg pwd "$(pwd)" > vars.json
           ansible-playbook playbook/playbook.yaml --extra-vars "@vars.json"
         env:
           GH_ACCESS_TOKEN: ${{ secrets.gh_access_token }}

playbook/group_vars/all/vars

@@ -26,7 +26,7 @@ pr_body: |
     >
     > | **Trigger-message** |
     > | - |
-    > | {{ author }}: {{ reason }} |
+    > | @{{ author }}: {{ reason }} |
 
     > [!TIP]
     > Please update the change type as appropriate.