Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Openshift compatibility #431

Closed
wants to merge 31 commits into from
Closed

[Merged by Bors] - Openshift compatibility #431

wants to merge 31 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Apr 4, 2023 •
edited
Loading

Description

Adds the service account to the daemonset. Part of stackabletech/issues#234

Openshift tests:
image

Updated tests following bump to operator-rs:
image

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 mentioned this pull request Apr 4, 2023
Closed
2 tasks
@adwk67 adwk67 self-assigned this Apr 5, 2023
@adwk67 adwk67 marked this pull request as ready for review April 5, 2023 11:40
@adwk67 adwk67 requested a review from a team April 5, 2023 11:43
@maltesander maltesander requested review from maltesander and removed request for a team April 6, 2023 10:35
maltesander
maltesander requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things left.

rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
maltesander
maltesander approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67
Copy link
Member Author

adwk67 commented Apr 12, 2023

bors merge

bors bot pushed a commit that referenced this pull request Apr 12, 2023
@adwk67 @maltesander
Openshift compatibility (#431)
aa6911c 
# Description

Adds the service account to the daemonset. Part of stackabletech/issues#234

Openshift tests:
![image](https://user-images.githubusercontent.com/1712947/230067303-9bfae613-d118-46bd-a612-2fc2446b21d9.png)

Updated tests following bump to operator-rs:
![image](https://user-images.githubusercontent.com/1712947/231166252-768ea1b5-8d27-4b5a-9f1f-bd2ed4201b1c.png)





Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Openshift compatibility [Merged by Bors] - Openshift compatibility Apr 12, 2023
@bors bors bot closed this Apr 12, 2023
@bors bors bot deleted the openshift-compatibility branch April 12, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@adwk67 adwk67

Labels
release/2023-04
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adwk67 @maltesander @lfrancke