Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Enable logging #420

Closed
wants to merge 35 commits into from
Closed

[Merged by Bors] - Enable logging #420

wants to merge 35 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 22, 2023 •
edited by siegfriedweber
Loading

Description

fixes #410

TODO:

  • Release operator-rs and switch to tag (for vector config)

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Feb 22, 2023
@maltesander maltesander mentioned this pull request Feb 22, 2023
Closed
5 tasks
@maltesander maltesander marked this pull request as ready for review February 27, 2023 09:45
siegfriedweber
siegfriedweber requested changes Mar 2, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks and the changelog must be updated.

rust/crd/src/lib.rs Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
tests/templates/kuttl/logging/opa-vector-aggregator-values.yaml.j2 Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
maltesander and others added 3 commits March 6, 2023 09:44
@maltesander @siegfriedweber
Update rust/crd/src/lib.rs
e0c23f3 
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@maltesander @siegfriedweber
Apply suggestions from code review
379aeff 
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@maltesander
added cluster_config for vectorAggregatorConfigMapName
2edbb77
@maltesander
Copy link
Member Author

maltesander commented Mar 6, 2023 •
edited
Loading

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/41/

siegfriedweber
siegfriedweber approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 6, 2023
@maltesander
Enable logging (#420)
9292417 
# Description

fixes #410

## TODO:

- [x] Release operator-rs and switch to tag (for vector config)



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable logging [Merged by Bors] - Enable logging Mar 6, 2023
@bors bors bot closed this Mar 6, 2023
@bors bors bot deleted the enable-logging branch March 6, 2023 10:59
@sbernauer sbernauer mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Log Aggregation for OPA
2 participants
@maltesander @siegfriedweber