Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update operator rs and fragment config #411

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Update operator rs and fragment config #411

wants to merge 7 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 13, 2023 •
edited by siegfriedweber
Loading

Description

  • updated operator-rs to 0.35.0
  • fragmented config

prerequisite for #410

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Feb 13, 2023
@maltesander maltesander mentioned this pull request Feb 13, 2023
Closed
5 tasks
siegfriedweber
siegfriedweber approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have only two minor remarks.

rust/operator-binary/Cargo.toml Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 13, 2023
@maltesander
Update operator rs and fragment config (#411)
4ff832b 
# Description

- updated operator-rs to 0.35.0 
- fragmented config

prerequisite for #410



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 13, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update operator rs and fragment config [Merged by Bors] - Update operator rs and fragment config Feb 13, 2023
@bors bors bot closed this Feb 13, 2023
@bors bors bot deleted the update-operator-rs-and-fragment-config branch February 13, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @siegfriedweber