Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support offline mode #391

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - Support offline mode #391

wants to merge 12 commits into from

Conversation

maltesander
Copy link
Member

Description

  • Using new opa images that contain the bundle builder
  • Changed init and bundle builder container to use the opa image

fixes #389

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team December 16, 2022 13:52
@maltesander maltesander self-assigned this Dec 16, 2022
@maltesander maltesander mentioned this pull request Dec 16, 2022
Closed
7 tasks
sbernauer
sbernauer approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when test pass

CHANGELOG.md Show resolved Hide resolved
docs/modules/ROOT/pages/implementation-notes.adoc Outdated Show resolved Hide resolved
@maltesander
Copy link
Member Author

maltesander commented Dec 16, 2022 •
edited
Loading

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/28/

maltesander and others added 2 commits December 16, 2022 15:28
@maltesander @sbernauer
Update docs/modules/ROOT/pages/implementation-notes.adoc
201dc21 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander @sbernauer
Update CHANGELOG.md
174ced9 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander maltesander marked this pull request as ready for review December 16, 2022 14:29
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 16, 2022
@maltesander
Support offline mode (#391)
752d57a 
# Description

- Using new opa images that contain the bundle builder
- Changed init and bundle builder container to use the opa image

fixes #389



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support offline mode [Merged by Bors] - Support offline mode Dec 16, 2022
@bors bors bot closed this Dec 16, 2022
@bors bors bot deleted the support-offline-mode branch December 16, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support offline mode
2 participants
@maltesander @sbernauer