Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Product image selection #385

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Product image selection #385

wants to merge 9 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Dec 5, 2022 •
edited
Loading

Description

fixes #384

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/23/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team December 5, 2022 15:50
@maltesander maltesander self-assigned this Dec 5, 2022
sbernauer
sbernauer requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pull Secrets on Pod are missing as well

rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
This was referenced Dec 5, 2022
Closed
Closed
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 6, 2022
@maltesander
Product image selection (#385)
e8e42e0 
# Description

fixes #384

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/23/



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Product image selection [Merged by Bors] - Product image selection Dec 6, 2022
@bors bors bot closed this Dec 6, 2022
@bors bors bot deleted the product-image-selection branch December 6, 2022 08:53
bors bot pushed a commit to stackabletech/trino-operator that referenced this pull request Dec 6, 2022
@maltesander
Product image selection (#356)
d9dc1d8 
# Description

fixes: #355

Waiting for OPA stackabletech/opa-operator#385 and Hive 
stackabletech/hive-operator#279 to be merged first.



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@maltesander maltesander mentioned this pull request Dec 15, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement product image selection
2 participants
@maltesander @sbernauer