Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update operator-rs to 0.27.1 #377

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Update operator-rs to 0.27.1 #377

wants to merge 5 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Nov 19, 2022 •
edited
Loading

Description

fixes #369

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/21/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team November 19, 2022 15:12
@maltesander maltesander self-assigned this Nov 19, 2022
@razvan razvan requested review from razvan and removed request for a team November 21, 2022 09:59
razvan
razvan reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for fixing clippy warnings

rust/crd/src/lib.rs Show resolved Hide resolved
maltesander and others added 2 commits November 21, 2022 11:33
@maltesander @razvan
Update rust/crd/src/lib.rs
a3fa2f0 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@maltesander
attempt to fix clippy
0bd6683
razvan
razvan approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Nov 21, 2022
@maltesander
Update operator-rs to 0.27.1 (#377)
e251382 
# Description

fixes #369

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/21/



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update operator-rs to 0.27.1 [Merged by Bors] - Update operator-rs to 0.27.1 Nov 21, 2022
@bors bors bot closed this Nov 21, 2022
@bors bors bot deleted the update_operator_rs_0_27_1 branch November 21, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump operator-rs to 0.27.1
2 participants
@maltesander @razvan