Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement resource requests and limits for OPA pods #347

Closed
wants to merge 10 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 15, 2022

Description

  • added cpu and memory resource limits

fixes #325

This currently only sets resource limits for the opa container. I created an issue #348 in case we ever need to provide the opa-bundle-builder container with more resources.

Test:
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/12/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Sep 15, 2022
@maltesander maltesander changed the title Resource limits Implement resource requests and limits for OPA pods Sep 15, 2022
@maltesander maltesander requested a review from a team September 15, 2022 16:36
@maltesander maltesander marked this pull request as ready for review September 15, 2022 16:36
CHANGELOG.md Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
tests/templates/kuttl/resources/01-install-opa.yaml.j2 Outdated Show resolved Hide resolved
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % opa-latest discussion

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 16, 2022
# Description

- added cpu and memory resource limits

fixes #325

This currently only sets resource limits for the `opa` container. I created an issue #348 in case we ever need to provide the `opa-bundle-builder` container with more resources.

Test:
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/12/



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement resource requests and limits for OPA pods [Merged by Bors] - Implement resource requests and limits for OPA pods Sep 16, 2022
@bors bors bot closed this Sep 16, 2022
@bors bors bot deleted the resource_limits branch September 16, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement resource requests and limits for OPA pods
2 participants