Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Rafctoring names. #252

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Rafctoring names. #252

wants to merge 5 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Mar 1, 2022

Description

As discussed at: stackabletech/operator-templating#89

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan requested a review from a team March 1, 2022 14:47
maltesander
maltesander requested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor things

CHANGELOG.md Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/commandline_args.adoc Show resolved Hide resolved
razvan and others added 3 commits March 1, 2022 16:03
@razvan @maltesander
Update CHANGELOG.md
4a833ac 
Co-authored-by: Malte Sander <contact@maltesander.com>
@razvan
Update docs
cb6c146
@razvan
Fix bundle builder cluster role name.
d89afc5
maltesander
maltesander approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors bot pushed a commit that referenced this pull request Mar 1, 2022
@razvan
Rafctoring names. (#252)
f6bd965 
## Description

As discussed at: stackabletech/operator-templating#89
@bors
Copy link
Contributor

bors bot commented Mar 1, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rafctoring names. [Merged by Bors] - Rafctoring names. Mar 1, 2022
@bors bors bot closed this Mar 1, 2022
@bors bors bot deleted the refactoring-naming branch March 1, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvan @maltesander