Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redesign #73

Merged
merged 21 commits into from
Aug 29, 2024
Merged

feat: redesign #73

merged 21 commits into from
Aug 29, 2024

Conversation

fhennig
Copy link
Member

@fhennig fhennig commented Aug 26, 2024 •
edited
Loading

preview here: stackabletech/documentation#653

  • colors updated
  • fonts updated
  • fonts are now pulled from fontsource instead of the deprecated typeface

This was referenced Aug 26, 2024
Closed
Closed
@fhennig
Copy link
Member Author

fhennig commented Aug 26, 2024 •
edited
Loading

todo:

  • fix colors
  • replace roboto mono with noto mono (maybe, might look nicer in context, especially in flowing text)

@fhennig fhennig mentioned this pull request Aug 26, 2024
Merged
This was referenced Aug 26, 2024
Closed
Closed
@xeniape
Copy link
Member

xeniape commented Aug 29, 2024

Just noting down something I noticed: In the website redesign when hovering over an item in the menu at the top, the dropdown menu seems to have a small shadow. I think it would be nice to have that as well in the docs for consistency.

image

@fhennig
Copy link
Member Author

fhennig commented Aug 29, 2024

Thanks @xeniape , added it 45d3e63

@fhennig fhennig self-assigned this Aug 29, 2024
@fhennig fhennig marked this pull request as ready for review August 29, 2024 07:33
xeniape
xeniape approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig fhennig merged commit c9a8e31 into stackable Aug 29, 2024
2 checks passed
@fhennig fhennig deleted the feat/redesign branch August 29, 2024 07:51
@nightkr
Copy link
Member

nightkr commented Sep 5, 2024

  • Where'd darkmode go?
  • Why is there so little contrast on the dropdowns? Off-white on white on white makes it hard to see where the click/hover zones are.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeniape xeniape xeniape approved these changes

Assignees

@fhennig fhennig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhennig @xeniape @nightkr