Small fixes #9
Merged
Small fixes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds any properties that are included in the Planet item metadata that doesn't map directly to a STAC metadata property. It will append a "pl:" prefix on these properties and include them in the STAC Item's properties.
I ran into an instance where I forgot to put 'catch_exceptions=False' in a new unit test, which ate some time up to debug. Refactor how we run CLI tests to standardize the way they run to avoid future issues and make it simpler to write new tests.
The collection should be set on the item_copy, not the original item.
This function was using 'map_items', which makes a copy of the catalog, and so did not mutate the input catalog. This was inconsistent with the other functions in the library and could easily cause confusion.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 55.17% 63.07% +7.90%
==========================================
Files 28 28
Lines 531 539 +8
==========================================
+ Hits 293 340 +47
+ Misses 238 199 -39
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a set of small fixes:
stac mergewhen copying assetsstac merge-has shortcut for--include-hrefsoption instac describe.stac copywill migrate the copied STAC to the latest version.Also refactored the unit tests to make writing CLI test a bit more consistent.