Added 'add' command to add an item to a catalog/collection #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volaya checking in on this PR, is this WIP or is it ready for review? |
|
@gadomski I added new tests and this should be ready for review |
gadomski
requested changes
Jul 23, 2021
There was a problem hiding this comment.
Thanks for adding the tests! I have one change requested in the unit tests (checking to make sure the item was added to the correct collection), and then a couple musing thoughts that aren't really change requests, just questions. Once the test change is made and CI is passing this looks good to go!
cuttlefish
reviewed
Jul 26, 2021
|
CI is failing, but it seems to fail in something not related to this PR. |
I've got a fix queued up in #198. |
gadomski
requested changes
Sep 13, 2021
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
gadomski
approved these changes
Sep 14, 2021
gadomski
added a commit
that referenced
this pull request
Sep 16, 2021
Also add changelog entry for #153
gadomski
added a commit
that referenced
this pull request
Sep 16, 2021
Also add changelog entry for #153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] The functionality is there, but the PR is missing a better collection of tests to test all options. I will work on adding them ASAP
This PR fixes #148