Fix exhaustive memory consumption

staabm · Sep 16, 2024 · 629c0e3 · 629c0e3
1 parent 6822306
commit 629c0e3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/TodoByTicketCollector.php b/src/TodoByTicketCollector.php
@@ -55,7 +55,12 @@ public function processNode(Node $node, Scope $scope)
             }
         }
 
-        return $tickets;
+        // don't return empty array so we don't pollute the result cache
+        // see https://github.com/phpstan/phpstan/discussions/11701#discussioncomment-10660711
+        if ($tickets !== []) {
+            return $tickets;
+        }
+        return null;
     }
 
     private function createPattern(): string